KeyPass milestone 1 delivery#5
Conversation
KeyPass milestone 1 delivery
oshakarishvili
left a comment
There was a problem hiding this comment.
Hi @uliana1one, great work! Approved from my end.
|
I particularly enjoyed the attention to detail in the docs and examples. Great work, well done. A couple things that came up in my review:
If you can address 2 and update it so I can finish my review this is approved on my end! |
|
Hey @sacha-l! For 1, I am not sure which exact issues you run into when running docker. It all works for me when I run it from a clean state but I would love to know what went wrong for you so I can fix it. For 2, I included more straightforward instructions and a couple boilerplate apps so you can see how it is intended to work even if the tutorials aren’t helpful enough. Please, let me know if anything is still unclear. I have also recorded a demo showing the boilerplate and authentication in action. For the third point, I actually considered using right-padded EVM addresses for Substrate, but I went with native SS58 addresses instead for a few practical reasons:
Let me know if there are any other questions or adjustments needed! |
sacha-l
left a comment
There was a problem hiding this comment.
Thank you for addressing my comments and making the updates. Looking forward to reviewing milestone 2.
|
Hey @uliana1one, the payout was made 3 days ago: https://polkadot.subsquare.io/treasury/child-bounties/63_3. Thanks for your patience. |
📬 Milestone Delivery Checklist
Link to the application pull request: Polkadot-Fast-Grants/apply#22